Projecteur icon indicating copy to clipboard operation
Projecteur copied to clipboard

Published 20 hours ago • verified publisher icon jahnf

[WIP] Various Wayland Fixes

Open mayanksuman opened this issue 4 years ago • 4 comments

  1. Implements xdg-desktop-portal based screenshot capture
  2. No QMenu without parent widget: as this causes issues with wayland as per https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes

mayanksuman avatar Nov 06 '21 14:11 mayanksuman

Thanks for the PR. Did you test, the context menu on Xorg? I remember vaguely, that the menu behaved weird of it had the application as a parent.

jahnf avatar Nov 08 '21 04:11 jahnf

Essentially your change to

new QMenu(qobject_cast<QWidget*>(m_trayIcon.get()))

will be the same as new QMenu(nullptr)

QSystemtrayIcon is not a QWidget, the cast will return a nullptr.

jahnf avatar Nov 08 '21 04:11 jahnf

@mayanksuman Thx for your PR. I gave it a try. :) It works -- except for the first seconds. At the beginning, I see several error messages. They state no screenshot could be taken. After a few seconds, it works.

@jahnf Will this PR be merged?

flipreverse avatar Nov 01 '23 19:11 flipreverse

Yes eventually, it will. sorry the project is moving slow currently - The screenshot issue is the least of the problems that occur with Wayland + Qt and the Projecteur that needs to be a window above others - which just doesn't work as with X anymore.

jahnf avatar Dec 21 '23 18:12 jahnf