MusicBot icon indicating copy to clipboard operation
MusicBot copied to clipboard
verified publisher icon jagrosh

Fix warnings and deprecations

Open t3rminus opened this issue 3 years ago • 1 comments

This pull request...

  • [ ] Fixes a bug
  • [ ] Introduces a new feature
  • [ ] Improves an existing feature
  • [X] Boosts code quality or performance

Description

Fixes a bunch of warnings and deprecations

Purpose

Keep things nice and clean :)

t3rminus avatar Apr 01 '22 01:04 t3rminus

I'm sorry for the lack of response. The reason we haven't really responded to this PR, is because we've been planning on doing our own major refactor when adding slash commands & localization to JMusicBot.

MichailiK avatar Jul 13 '22 08:07 MichailiK

hows major refactor coming along

bigkitttty avatar Sep 18 '22 20:09 bigkitttty

We are first adding slash commands & l10n to JDA-Utilities, before we start work on JMusicBot.

MichailiK avatar Sep 18 '22 21:09 MichailiK

Thank you, but what's JDA-Utilities?

bigkitttty avatar Sep 18 '22 22:09 bigkitttty

JDA-Utilities is a library which manages all of JMusicBot's commands (and does some other things too). Once we add slash commands to JDA-Utilities, we can update JMusicBot to use slash commands, and clean up the code along the way.

MichailiK avatar Sep 18 '22 22:09 MichailiK

Why is JDA-Utilities in Java not js

bigkitttty avatar Sep 19 '22 00:09 bigkitttty

A note js is for JavaScript

bigkitttty avatar Sep 19 '22 03:09 bigkitttty

We use Java for several reasons, such as lavaplayer, a popular library for playing music on Discord, is also written in Java.

Pull requests are not the right place for asking these questions. Please stop commenting about this here.

MichailiK avatar Sep 19 '22 06:09 MichailiK