php-binance-api icon indicating copy to clipboard operation
php-binance-api copied to clipboard

Implement PSR-3 logging interface

Open estebangarcia opened this issue 3 years ago • 2 comments

I'm integrating this library on an HTTP API using Laravel. The "echo" style logging would show up sometimes on the HTTP Responses, breaking the JSON parsing for the clients.

I created a simple PS3 logger that echoes the messages called "EchoLogger" and modified the constructor to be able to override it for anyone that would like to use a different LoggingInterface.

estebangarcia avatar Jun 01 '21 14:06 estebangarcia

Hi @estebangarcia , I like the use of echologger, but not everybody is using composer for using this binance api php file. So people that just use the php file in their environment would get an error as they might not have the psr logger. In fact most of those 'echo' should maybe throw an error and not just echo things...

ePascalC avatar Jun 04 '21 15:06 ePascalC

needs rebase

dmzoneill avatar Jul 06 '21 08:07 dmzoneill