php-binance-api icon indicating copy to clipboard operation
php-binance-api copied to clipboard

futures

Open AlexVanchov opened this issue 4 years ago • 12 comments

AlexVanchov avatar Mar 25 '21 08:03 AlexVanchov

hi, thanks for the work. Could you kindly rebase; resolving the merge conflicts?

thanks

dmzoneill avatar Mar 27 '21 13:03 dmzoneill

I am still editing and adding futures for other functions. I will check out merge conflicts

AlexVanchov avatar Mar 27 '21 14:03 AlexVanchov

I added FAPI class where all functions are the same but they are linked to futures endpoints. There is change in userData stream where you can add function which can be runner on connection to the WebSocket. You can review it now

AlexVanchov avatar Mar 29 '21 06:03 AlexVanchov

Can you please rebase?

dmzoneill avatar Mar 29 '21 17:03 dmzoneill

Can you please rebase?

I haven't used it before. I don't know if that should happen.

Command: git rebase Result: Current branch master is up to date.

AlexVanchov avatar Mar 29 '21 20:03 AlexVanchov

Can you please rebase?

I haven't used it before. I don't know if that should happen.

Command: git rebase Result: Current branch master is up to date.

You need to rebase onto jaggedsoft:master. You're likely doing the default where it's your fork's master.

YetiCGN avatar Mar 29 '21 21:03 YetiCGN

I rebased. Anything else to do?

AlexVanchov avatar Apr 01 '21 06:04 AlexVanchov

Hello @AlexVanchov,

Did you implement a getPositions function? I could not find it in changes.

llomgui avatar Apr 01 '21 08:04 llomgui

@AlexVanchov

did you push the changes to the merge request.. still tell me here there are maege conflicts

This branch cannot be rebased due to conflicts Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch.

dmzoneill avatar Apr 05 '21 13:04 dmzoneill

@AlexVanchov

I would love to see this merge. can you please rebase, squash and push the commits?

dmzoneill avatar Apr 09 '21 19:04 dmzoneill

It still have some bugs with futures for some functions. I will pull request again when it's ready

AlexVanchov avatar Apr 13 '21 07:04 AlexVanchov

any update here?

dmzoneill avatar May 05 '21 18:05 dmzoneill