Mikael Jagan

Results 31 comments of Mikael Jagan

An even nicer (and still backwards compatible) interface might be: ```r library("lubridate") wday(1:7, from_sunday = 1, to_sunday = 1) ## [1] 1 2 3 4 5 6 7 wday(1:7, from_sunday...

`wday.numeric(x, week_start)` seems to assume that `x` uses the coding 1=Sunday, independently of `week_start`. `week_start` controls the coding of the result, and nothing else. That's fine, but the coding that...

@vspinu I've added a PR with a couple of options for improving the interface. (Not sure if you would have have received a notification.)

I left [one comment](https://github.com/RcppCore/RcppEigen/commit/4db13cb44439c5f296a3310ae16ce8067494b1af#r137320746) on Dirk's merge commit, but apart from that it seems OK.

I've not seen a reference discussing the details of a Bunch-Kaufman factorization other than `A = L*D*L**T`, so I can't comment on the language choice. But the motivation of the...

I should add that `dsptrf.f` has https://github.com/Reference-LAPACK/lapack/blob/a83d8d28214f1a3760943d56e49c58a4e55ef13d/SRC/dsptrf.f#L117 and is consistent with `dsptri.f` and `dsptrs.f`. And my tests again indicate that `U*D*U**T` is correct there. So the language in `dsytrf.f` is...

I wonder if this should happen soon-ish, so that **glmmTMB** can get the density functions directly from **TMB** instead of [copying the code into its own sources](https://github.com/glmmTMB/glmmTMB/commit/edc2d09a82fdddbbf322fb258d455bed15ecca05). Probably it is...

The `d*` functions in the header take as argument the transformed parameter and compute the probability density in the space of the untransformed parameter. The distribution of the transformed parameter...

Er, right, yes, I managed to confuse myself, not having read carefully enough (your comment and my own documentation) ... As you say, `dwishart` does not integrate to one because...

OK. I'll work on those alternate implementations "soon" and update here.