Javier
Javier
here draft PR: https://github.com/adap/flower/pull/2239
> @jafermarq I see that here pylint doesn't pass (`flanders/utils.py:11:0: E0401: Unable to import 'natsort' (import-error)`), however locally it runs without warnings. Any clue? I added `natsort` to `pyproject.toml` and...
> > Hey @edogab33, > > I still think there is a lot of value that can be added to this baseline if you could add at least one other...
Hey @edogab33 , let me know if you'd like to discuss something related to the review above
> @jafermarq I've updated the code, now it's alligned with the most recent version that I've written. Let me update the README and test everything before starting a code review....
Hi @edogab33 , i fixed a couple of small formatting errors. All tests pass. Let me know if there is something pending you'd like to add to your baseline!
> > Hi @edogab33 , i fixed a couple of small formatting errors. All tests pass. Let me know if there is something pending you'd like to add to your...
What about this one @edogab33 ?
> @jafermarq should I rename the title of the PR in: `feat(baselines) Add FLANDERS`? yes please. maybe "`feat(baselines) Add FLANDERS baseline`"?
> @jafermarq do you know what's the problem with the test? All seems good now. I'll review soon.