cached icon indicating copy to clipboard operation
cached copied to clipboard

Naming on Cached trait

Open Stargateur opened this issue 5 years ago • 4 comments

All method on the Cached trait are named cache_*, it's very redundant. I think we should remove this noise.

Stargateur avatar Jun 29 '20 12:06 Stargateur

I guess it's a bit redundant, but at least means you never need to disambiguate the calls with "fully qualified call syntax"

jaemk avatar Jul 02 '20 01:07 jaemk

I see no case where a disambiguate call would be needed in practice on the cache of Cached.

Stargateur avatar Jul 02 '20 07:07 Stargateur

I'd be open to phasing in methods without the cache prefix and having their default implementations call the existing cache_ methods until they are removed in the future.

jaemk avatar Jul 03 '20 14:07 jaemk

Problem is if we just add new method this will make implementation annoying, and if we ship it as provided method, this will still be a hard breaking change. If we do the other way around, making actual method provided method. This would allow a better soft breaking change.

Unless you feel strong about or we have more people thinking like me I will let this issue open until people that used this crate agree or not.

Stargateur avatar Aug 15 '20 09:08 Stargateur