jaemk
Use Duration instead of raw seconds and millis
@jaemk can you approve the workflow?
I ran most of the tests locally but got connection errors with the redis tests. I'm hoping the ci is configured properly.
@jaemk Thanks for approving the workflow! I have no idea what caused it to fail. It didn't get to the part where it runs the tests.
Looks like the workflow definition needs to be updated.
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
Is it as simple as updating the version to 3 or 4? or is that going to break other things? Edit: according to the migration guide it is fully backward compatible.
Those test errors are strange and I'm not sure why I didn't see them in my run.... but I've pushed some updates that hopefully resolve the failures.
Edit: Apparently I had to run cargo test --doc for some of these. My latest commit should address what's left.
@jaemk I am not understanding the current check failure...
I think it's complaining that the readme was changed? But I thought I read in the contributing guidelines to update the readme.
@jaemk I had misunderstood the error. The issue should be fixed now if you re-approve the workflow