jaeger icon indicating copy to clipboard operation
jaeger copied to clipboard

[V2]Add Script for metrics markdown table

Open vvs-personalstash opened this issue 1 year ago • 2 comments

Description of the changes

  • Added a script for creating a markdown table to view and compare v1 and v2 metrics using json generated by compare metrics

Checklist

  • *[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
  • *[x] I have signed all commits
  • [ ] I have added unit tests for the new functionality
  • *[x] I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: yarn lint and yarn test

vvs-personalstash avatar Sep 05 '24 17:09 vvs-personalstash

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.46%. Comparing base (49f33a4) to head (2e134eb). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5941   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         355      355           
  Lines       20149    20149           
=======================================
  Hits        19436    19436           
  Misses        526      526           
  Partials      187      187           
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (ø)
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) :arrow_down:
elasticsearch-8.x-v1 18.85% <ø> (+<0.01%) :arrow_up:
elasticsearch-8.x-v2 1.66% <ø> (ø)
grpc_v1 9.43% <ø> (ø)
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.72% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) :arrow_down:
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Sep 05 '24 17:09 codecov[bot]

In terminal, run make fmt and push again.

Wise-Wizard avatar Sep 06 '24 04:09 Wise-Wizard

@yurishkuro I have made changes as per your reviews,kindly review if there are any changes or errors i may have not noticed

vvs-personalstash avatar Nov 04 '24 06:11 vvs-personalstash