chore: use errors.New to replace fmt.Errorf with no parameters will much better

[ChengenH]

use errors.New to replace fmt.Errorf with no parameters will much better

[ChengenH]

Isn’t there any linter like errorlint that could ensure such best practice ?

It's not serious, so...

[mmorel-35]

"Heaven is in the details" would say Uncle Bob 😉

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.13%. Comparing base (44484ac) to head (3bfd244).

:exclamation: There is a different number of reports uploaded between BASE (44484ac) and HEAD (3bfd244). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (44484ac)	HEAD (3bfd244)
unittests	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5377       +/-   ##
===========================================
- Coverage   96.38%   54.13%   -42.25%     
===========================================
  Files         329      163      -166     
  Lines       16060     8412     -7648     
===========================================
- Hits        15479     4554    -10925     
- Misses        404     3414     +3010     
- Partials      177      444      +267     

Flag	Coverage Δ
badger_v1	8.04% <ø> (ø)
badger_v2	1.92% <ø> (ø)
cassandra-3.x-v1	16.60% <ø> (ø)
cassandra-3.x-v2	1.84% <ø> (ø)
cassandra-4.x-v1	16.60% <ø> (ø)
cassandra-4.x-v2	1.84% <ø> (ø)
elasticsearch-7.x-v1	18.87% <ø> (ø)
elasticsearch-8.x-v1	19.07% <ø> (-0.02%)	:arrow_down:
elasticsearch-8.x-v2	19.07% <ø> (-0.02%)	:arrow_down:
grpc_v1	9.46% <ø> (-0.02%)	:arrow_down:
grpc_v2	7.47% <ø> (-0.02%)	:arrow_down:
kafka	9.76% <ø> (ø)
opensearch-1.x-v1	18.93% <ø> (+0.01%)	:arrow_up:
opensearch-2.x-v1	18.92% <ø> (-0.02%)	:arrow_down:
opensearch-2.x-v2	18.93% <ø> (+0.01%)	:arrow_up:
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[yurishkuro]

alternatively, I agree with @mmorel-35 , we should find a linter that catches this, rather than doing manually. I thought revive linter would do that (#5505), but it doesn't.

[yurishkuro]

no follow-up, closing