jaeger icon indicating copy to clipboard operation
jaeger copied to clipboard

Remove dependency on sarama-cluster (Kafka driver)

Open yurishkuro opened this issue 6 years ago • 8 comments

  • partitions not picked up on rebalance: https://github.com/bsm/sarama-cluster/issues/235
  • partitions are can be held even when no work is being done by client: https://github.com/bsm/sarama-cluster/issues/261
  • potential deadlock when rebalancing: https://github.com/bsm/sarama-cluster/issues/255#issuecomment-413967695

yurishkuro avatar Sep 05 '18 22:09 yurishkuro

Transferring #1090 by @vprithvi here:

Use high level consumer groups from Shopify/sarama#1099 instead of sarama-cluster. This is a rewrite of high level consumer functionality and can side step the issues described in #1052

yurishkuro avatar Oct 06 '18 20:10 yurishkuro

Instead of sarama You can take a look at https://github.com/confluentinc/confluent-kafka-go It's a light wrapper for C implementation of kafka client (librdkafka) and AFAIK is more stable/reliable than shopify/sarama.

marqc avatar Oct 19 '18 14:10 marqc

@marqc Thanks for the suggestion - we haven't yet explored it because we weren't familiar with how the build and deployment process changes when depending on a native bindings.

vprithvi avatar Nov 01 '18 20:11 vprithvi

My vote is against libraries that depend on native bindings. Not only do they complicate the build in CI, they increase the barrier to entry for new contributors.

yurishkuro avatar Nov 01 '18 20:11 yurishkuro

Ironically, given my C++ background, I happen to agree. Also, go get is completely useless for any Go package using non-Go build dependencies.

isaachier avatar Nov 01 '18 21:11 isaachier

👍 on not using the C wrapper.

We used it in a project internally and had a hard time making it work on older kernel (especially having a statically-linked binary)

ledor473 avatar Nov 05 '18 19:11 ledor473

is anyone working on this issue, i have bit experience working with Kafka and sarama can take this task if this is okay ?

clock21am avatar Jun 05 '21 17:06 clock21am

Is anyone actively working on this? We still see the issue with Jaeger version 1.56(latest as of today).

We see that rebalancing is not trigerred upon change in partitions, eventually causing data loss.

abhishek-j16 avatar Apr 08 '24 04:04 abhishek-j16