jaeger-ui icon indicating copy to clipboard operation
jaeger-ui copied to clipboard

Published 20 hours ago • verified publisher icon jaegertracing

Add an about page

Open delanym opened this issue 3 years ago • 6 comments

Please add an about page that gives some basic info like the version number.

delanym avatar Jan 20 '22 12:01 delanym

image

yurishkuro avatar Jan 20 '22 12:01 yurishkuro

@yurishkuro you're obviously not using the example config from https://www.jaegertracing.io/docs/1.30/frontend-ui/ so what config are you using?

delanym avatar Jan 20 '22 13:01 delanym

Can you rather do what everyone else does and use a config file and mount to overwrite it. Then we can leave out the extra --query.ui-config and you can save on writing documentation?

delanym avatar Jan 20 '22 13:01 delanym

I'm not using any config, just default all-in-one image.

yurishkuro avatar Jan 20 '22 14:01 yurishkuro

I'm also using that image, but I'd like to configure something. When I override the config, the version info disappears, because there's no documentation on how to config it and no example to copy from.

delanym avatar Jan 20 '22 14:01 delanym

I don't think it's possible right now if you override config, since the versions are built into the default config, there's no logic to just append them to whatever the menu is.

https://github.com/jaegertracing/jaeger-ui/blob/72191f11000cb78f7d2508ea6d0c082c46d122b0/packages/jaeger-ui/src/constants/default-config.tsx#L63-L74

yurishkuro avatar Jan 20 '22 14:01 yurishkuro