jaeger-ui icon indicating copy to clipboard operation
jaeger-ui copied to clipboard

Question: change the layout selection for deep dependency graph view (view=ddg)

Open christine-gong opened this issue 5 years ago • 5 comments

Requirement - what kind of business use case are you trying to solve?

can we change the default choice of layout selection to be one node per resource in this section: Screen Shot 2020-07-16 at 3 32 48 PM Current default is show paths to focal node

christine-gong avatar Jul 17 '20 17:07 christine-gong

I don't have a strong opinion on the specific default itself, but I think it would be useful to have it configurable per installation in the ui config, so that the change is backwards compatible in case some people really like the current default.

yurishkuro avatar Jul 17 '20 17:07 yurishkuro

@yurishkuro yeah it would be nice to be configurable as part of ui deployment.

christine-gong avatar Jul 17 '20 18:07 christine-gong

can I work on this issue?

Leena1666 avatar Apr 19 '21 16:04 Leena1666

@Leena1666 it's yours!

albertteoh avatar Apr 20 '21 06:04 albertteoh

I am aware that this issue has already been assigned, but I did it nevertheless given that it was assigned almost 6 months ago. Do let me know if I should close my PR.

PawBud avatar Feb 23 '22 19:02 PawBud

@yurishkuro, Is this issue still open? I would like to work on it!

Wise-Wizard avatar Nov 25 '23 06:11 Wise-Wizard

It's open

yurishkuro avatar Nov 25 '23 07:11 yurishkuro

I had a question regarding this issue, the default option should not be set to One Node per resource, but rather the default option should be configurable as per the User right?

Wise-Wizard avatar Nov 26 '23 12:11 Wise-Wizard

It should be configurable by user, but in the absence of such configuration it should behave the same as today.

yurishkuro avatar Nov 26 '23 14:11 yurishkuro

Understood! Thanks for clarifying!

Wise-Wizard avatar Nov 26 '23 15:11 Wise-Wizard

Hi, I thought configurable by user meant that the end user can set any of the option as defualt and was thinking of adding set as default as an additional option and had made the required changes for that, and was about to raise a PR but then I took a look at the below Thread: https://github.com/jaegertracing/jaeger-ui/pull/891 and found out there are some entirely different expectations and I have misunderstood them something to do with the below picture Screenshot 2023-12-15 135129 Can you please clarify the requirements again as to what is expected?

Wise-Wizard avatar Dec 15 '23 08:12 Wise-Wizard

configurable by user meant that the end user can set any of the option as default

I think there's even a simpler solution - store last used option in local storage and apply it on new screens. Changing default via configuration would be next level, very high friction for small benefit.

yurishkuro avatar Dec 15 '23 15:12 yurishkuro

Got it thanks a lot! Will implement that itself

Wise-Wizard avatar Dec 17 '23 13:12 Wise-Wizard