jaeger-ui icon indicating copy to clipboard operation
jaeger-ui copied to clipboard

Add click to copy

Open Darshit42 opened this issue 6 months ago • 3 comments

Which problem is this PR solving?

  • This is a follow up pr to #2815
  • Resolves #2813

Description of the changes

  • added a clicktocopy component and changed relevant test cases

How was this change tested?

  • on UI user can see copy to clipboard when hovered over trace id and when clicked it copies the trace id to clipboard before changes

after changes image

Checklist

  • [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
  • [x] I have signed all commits
  • [x] I have added unit tests for the new functionality
  • [x] I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: npm run lint and npm run test

Darshit42 avatar Jun 04 '25 13:06 Darshit42

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

graphite-app[bot] avatar Jun 04 '25 13:06 graphite-app[bot]

@yurishkuro @Parship999 I have signed the commits and created a new pr I have one question the test in resultitem.test.js was failing even though I haven't changed its jsx so I just specified test id I hope it works

Darshit42 avatar Jun 04 '25 13:06 Darshit42

Codecov Report

Attention: Patch coverage is 32.25806% with 21 lines in your changes missing coverage. Please review.

Project coverage is 97.13%. Comparing base (677e893) to head (7097083). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...es/jaeger-ui/src/components/common/ClickToCopy.tsx 30.00% 21 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
- Coverage   97.39%   97.13%   -0.26%     
==========================================
  Files         256      257       +1     
  Lines        7975     8005      +30     
  Branches     2085     2068      -17     
==========================================
+ Hits         7767     7776       +9     
- Misses        208      229      +21     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 07 '25 15:06 codecov[bot]

@Darshit42 please don't merge main unless you are making other changes. All you achieve is me having to come back to the PR and approve CI runs, but then you merge again and CI checks are gone.

yurishkuro avatar Jun 24 '25 16:06 yurishkuro

@Darshit42 please don't merge main unless you are making other changes. All you achieve is me having to come back to the PR and approve CI runs, but then you merge again and CI checks are gone.

sorry for any trouble caused, I didn't know about that. I'll keep that in mind from now on

Darshit42 avatar Jun 25 '25 15:06 Darshit42