jaeger-operator
jaeger-operator copied to clipboard
jaegertracing
Support rollover for archive storage
When --es-archive.enabled=true --es-archive.use-aliases=true are present in the storage options the rollover init (ES storage dependency) and rollover rollover (cron job) jobs should be created.
- [ ] support rollover for archive
- [ ] support index cleaner for archive (which works only for archive anyway)
General question: What are the implications if the CR enables and then disables these options? (same for normal storage i.e. non-archive).
Do we need the operator to perform any additional actions when enabling rollover where ES cluster already exists - and similarly if moving from using rollover to no longer using rollover?
General question: What are the implications if the CR enables and then disables these options? (same for normal storage i.e. non-archive).
none, rollover is enabled or disabled purely based on storage options - see my first comment.
Do we need the operator to perform any additional actions when enabling rollover where ES cluster already exists - and similarly if moving from using rollover to no longer using rollover?
migration to/from rollover/daily indices is not supported. Users would have to do that manually. Migration from rollover to daily indices might be challenging and we haven't considered it when we were working on rollover.
@jpkrohling Is there any way the operator could prevent such upgrades? i.e. if user goes from a valid to an invalid state - prevent the invalid state being acted upon?
We should probably have the same check when changing storage backends or strategies.
Sort of. We cannot prevent updates to the CR, but we can revert the user's change. Inside the controller's applyElasticsearch, we could place a check and verify this specific case. If the new value is incompatible with the previous, revert the change and continue the reconciliation, so that the updated CR is persisted.
We should probably have the same check when changing storage backends or strategies.
We support changing storage backends and strategies.