jaeger-operator icon indicating copy to clipboard operation
jaeger-operator copied to clipboard

feat: added missing test for elasticsearch reconciler

Open Ankit152 opened this issue 1 year ago • 1 comments

Which problem is this PR solving?

  • Missing unit test for controllers/elasticsearch

Description of the changes

  • Adds missing unit test for controllers/elasticsearch

How was this change tested?

  • Tested locally make test-unit

Checklist

  • [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
  • [x] I have signed all commits
  • [ ] I have added unit tests for the new functionality
  • [ ] I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: yarn lint and yarn test

Ankit152 avatar Aug 15 '24 08:08 Ankit152

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.47%. Comparing base (e5546c7) to head (7870cdd). Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2662      +/-   ##
==========================================
+ Coverage   75.41%   75.47%   +0.05%     
==========================================
  Files         124      124              
  Lines        8525     8525              
==========================================
+ Hits         6429     6434       +5     
+ Misses       1899     1894       -5     
  Partials      197      197              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 15 '24 08:08 codecov[bot]