jaeger-operator icon indicating copy to clipboard operation
jaeger-operator copied to clipboard

Bump k8s libs to 1.30.x

Open pavolloffay opened this issue 1 year ago • 3 comments

Supersedes #2626

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

  • [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
  • [ ] I have signed all commits
  • [ ] I have added unit tests for the new functionality
  • [ ] I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: yarn lint and yarn test

pavolloffay avatar Aug 09 '24 09:08 pavolloffay

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.35%. Comparing base (fcba408) to head (1db3286). Report is 114 commits behind head on main.

Files with missing lines Patch % Lines
controllers/appsv1/deployment_webhook.go 50.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2649   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files         124      124           
  Lines        8525     8525           
=======================================
  Hits         6424     6424           
  Misses       1904     1904           
  Partials      197      197           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 09 '24 09:08 codecov[bot]

the CI fails on

The CustomResourceDefinition "jaegers.jaegertracing.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

pavolloffay avatar Aug 09 '24 14:08 pavolloffay

Do not merge this PR. The large CRD cannot be installe with k apply -f I will try to find a better approach

pavolloffay avatar Aug 12 '24 12:08 pavolloffay