fixes #2225
By providing default ingressClass using detectDefaultIngressClass func updated API call to use client.Reader instead of client.Client
Which problem is this PR solving?
- Resolve #2225
Description of the changes
- detectDefaultIngressClass func updated API call to use client.Reader instead of client.Client
How was this change tested?
- By running TestDetectDefaultIngressClass in autodetect/main_test.go
Checklist
- [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
- for
jaeger:make lint test - for
jaeger-ui:yarn lintandyarn test
- for
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.71%. Comparing base (
70e511a) to head (f82e648).
Additional details and impacted files
@@ Coverage Diff @@
## main #2622 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 102 102
Lines 7308 7308
=======================================
Hits 6410 6410
Misses 701 701
Partials 197 197
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for your contribution! Can you create a test?
Hi, @iblancasa test is already preset in pkg/autodetect/main_test.go and its working. Do i need to add anything else ?
I was thinking more about an E2E test or adding a new test. If after the change, none of the tests are modified it means we are not checking for the correct result.