[Feature]: Add PROMETHEUS_SERVER_URL to jaeger query spec

[thomaspaulin]

Requirement

As a Jaeger operator with an independently deployed Prometheus I want to specify where my Prometheus lives so that I make use of Service Performance Monitoring of my services from within the Jaeger UI

Problem

We can specify that we should be using Prometheus, but not how to reach Prometheus, despite it being to the metricsStorage option.

Proposal

Add the PROMETHEUS_SERVER_URL setting at the same level as METRICS_STORAGE_TYPE one, a la

query:
  metricsStorage: 
    type: prometheus
    server-url: <my-prometheus-here>:9090

Open questions

No response

[iblancasa]

Would you like to send a PR?

[antoniomerlin]

Hi, if this is not assigned can i take it.

[antoniomerlin]

Hi, @iblancasa is the spec structure is fine:-

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: simplest
  namespace: observability
spec:
  allInOne:
    metricsStorage:
      type: prometheus
      server-url: http://prometheus:9090 // This would be attach to container as PROMETHEUS_SERVER_URL env variable.

[antoniomerlin]

Hi, just a query if i use this definition :-

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: simplest
  namespace: observability
spec:
  query:
    metricsStorage:
      type: prometheus

I am unable to any value in q.jaeger.Spec.Query.MetricsStorage.Type in pkg/deployment/query.go line no. 131

[iblancasa]

Hi, @iblancasa is the spec structure is fine:-

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: simplest
  namespace: observability
spec:
  allInOne:
    metricsStorage:
      type: prometheus
      server-url: http://prometheus:9090 // This would be attach to container as PROMETHEUS_SERVER_URL env variable.

Yes.

I am unable to any value in q.jaeger.Spec.Query.MetricsStorage.Type in pkg/deployment/query.go line no. 131

You need to add it to the JaegerMetricsStorageSpec and it will be got from the JSON.

[antoniomerlin]

Hi, @iblancasa is the spec structure is fine:-

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: simplest
  namespace: observability
spec:
  allInOne:
    metricsStorage:
      type: prometheus
      server-url: http://prometheus:9090 // This would be attach to container as PROMETHEUS_SERVER_URL env variable.

Yes.

I am unable to any value in q.jaeger.Spec.Query.MetricsStorage.Type in pkg/deployment/query.go line no. 131

You need to add it to the JaegerMetricsStorageSpec and it will be got from the JSON. Hi, @iblancasa if its okay can you hide that prometheus URL in your comment accidentally copied.