jaeger-operator icon indicating copy to clipboard operation
jaeger-operator copied to clipboard

AllInOne doesn't support priorityClass

Open arminc opened this issue 2 years ago • 3 comments

Describe the bug The query, agent and collector allow us to set the priorityClassName but the AllInOne doesn't.

To Reproduce AllInOne doesn't have the priorityClassName https://github.com/jaegertracing/jaeger-operator/blob/39bdf765d8cef2a81456111d3d9b88e2e7cf9509/pkg/apis/jaegertracing/v1/jaeger_types.go#L368

While the Collector for example does have it: https://github.com/jaegertracing/jaeger-operator/blob/39bdf765d8cef2a81456111d3d9b88e2e7cf9509/pkg/apis/jaegertracing/v1/jaeger_types.go#L441

Expected behavior To be able to specify priorityClassName for the AllInOne.

Version (please complete the following information): Latest

arminc avatar Oct 27 '21 16:10 arminc

thanks for submitting the issue.

@arminc would you like to contribute this feature?

pavolloffay avatar Nov 01 '21 14:11 pavolloffay

@pavolloffay I was planning to but very busy, will try to fix it when I can find some time.

arminc avatar Nov 03 '21 07:11 arminc

@pavolloffay the esCleaner doesnt support priorityClass neither, I'm not sure if we should add that as a requirement to this issue @arminc or if its best to create another issue just for the esCleaner job

djsly avatar Nov 08 '21 16:11 djsly

@pavolloffay if this issue is still pending, I can pick it up. It looks like an easy feature.

I can add the priorityClass option to the JaegerAllInOneSpec.

csp197 avatar Mar 07 '23 18:03 csp197

@arminc @pavolloffay the above pr solves this issue and is ready for review thanks!

sonofgibs avatar May 18 '23 17:05 sonofgibs