jaeger-operator icon indicating copy to clipboard operation
jaeger-operator copied to clipboard

Published 20 hours ago • verified publisher icon jaegertracing

After #959 operator does not update sidecar arguments

Open ctron opened this issue 4 years ago • 6 comments

After upgrading, and having the fix for #959, the TLS configuration was still broken, as the controller did not update the arguments of the sidecar.

Deleting the deployment triggered the re-creation of the side and brought back tracing.

ctron avatar May 06 '20 12:05 ctron

@ctron Hi. I assume you are running on OpenShift?

Can you confirm the version you were upgrading from?

objectiser avatar May 06 '20 13:05 objectiser

@ctron Hi. I assume you are running on OpenShift?

Yes, indeed :grin:

Can you confirm the version you were upgrading from?

I can't really tell. The status section still reports it is 1.1.16.0, which is another bug I guess. Now it is 1.17.1. But I am not sure what was in the middle.

ctron avatar May 06 '20 14:05 ctron

Ok thanks - we will try to reproduce.

objectiser avatar May 06 '20 14:05 objectiser

cc @rubenvp8510

jpkrohling avatar Jun 09 '20 08:06 jpkrohling

I experience something similar while running the Jaeger Operator v 1.17.3 in OCP 4.3. If a Pod with the Jaeger sidecar also happens to have the Istio sidecar. Even with gRPC configured to use TLS on the collector and injected sidecar, as mentioned in #959, I see:

transport: authentication handshake failed: tls: first record does not look like a TLS handshake

But if I remove spec.template.metadata.annotations sidecar.istio.io/inject: 'true' from my Deployment then I no longer see errors in between the Jaeger agent sidecar and the collector.

tux-o-matic avatar Jun 29 '20 11:06 tux-o-matic

@tux-o-matic I think this sounds like a separate issue - nothing to do with sidecar injected agent flags not being updated on upgrade. Could you create a separate issue?

objectiser avatar Jun 29 '20 13:06 objectiser