jaeger-openshift icon indicating copy to clipboard operation
jaeger-openshift copied to clipboard

Move collector route to a separate file + test it

Open pavolloffay opened this issue 8 years ago • 7 comments

pavolloffay avatar Feb 23 '18 11:02 pavolloffay

Re-opening - let's improve this and move it to a separate resource file. @kevinearls should confirm how it will be tested

pavolloffay avatar Feb 23 '18 16:02 pavolloffay

@pavolloffay I've confirmed this manually by taking the following steps

  1. Deploying Jaeger and ElasticSearch to minishift using the production templates
  2. Created a route to the collector using the "oc create route edge" command that you added to the readme.
  3. Ran the CreateTraces program from https://github.com/Hawkular-QE/jaeger-standalone-performance-tests
  4. Validated the trace count with "curl http://elasticsearch:9200/jaeger-span-2018-02-26/_count"

Everything worked correctly. Is this sufficient or do we need to add an automated test somewhere?

kevinearls avatar Feb 26 '18 16:02 kevinearls

Would that test work given that jenkins and tests are executed from inside the cluster?

pavolloffay avatar Feb 26 '18 17:02 pavolloffay

At the moment all tests are executed from inside the cluster.

kevinearls avatar Feb 27 '18 08:02 kevinearls

@kevinearls could you confirm that a test could be implemented for this route given that tests are executed from inside the cluster?

pavolloffay avatar Mar 01 '18 11:03 pavolloffay

@pavolloffay I've submitted https://github.com/jaegertracing/jaeger-openshift/pull/57 . This will create the route and test it using a job that runs in Jenkins inside the cluster. I've manually tested it from outside the cluster, but at the moment we don't have a non-OpenShift Jenkins we can use.

kevinearls avatar Mar 01 '18 16:03 kevinearls

Let's keep this open, until the route is defined in a separate file

pavolloffay avatar Mar 26 '18 12:03 pavolloffay