helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard
verified publisher icon jaegertracing

[jaeger] feat: add option to add "envFrom" in deployments

Open sedflix opened this issue 3 years ago • 1 comments

What this PR does

This PR adds an option of giving "envFrom" to the deployment manifest.

Checklist

  • [x] DCO signed
  • [x] Commits are GPG signed
  • [x] Chart Version bumped
  • [x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • [x] README.md has been updated to match version/contain new values (> not sure where to update new version in the readme)

sedflix avatar Jul 21 '22 10:07 sedflix

@sedflix the commit needs to be GPG signed. Can you do that please.

mehta-ankit avatar Jul 21 '22 13:07 mehta-ankit

@sedflix can you resolve the conflicts and GPG sign the commit please.

mehta-ankit avatar Jan 10 '23 14:01 mehta-ankit

@sedflix ping

pavelnikolov avatar Mar 08 '23 13:03 pavelnikolov

@sedflix

Merging is blocked The base branch requires all commits to be signed

pavelnikolov avatar Mar 10 '23 10:03 pavelnikolov

I don't understand why this keeps failing. Screenshot 2023-05-23 at 11 15 39 I read the docs and it seems that it falls in this case.

@sedflix Could you, please, try to rebase locally and force push with a signed commit. Hopefully, that will resolve the problem.

pavelnikolov avatar May 23 '23 09:05 pavelnikolov