helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[jaeger] Ingester adds env variables for kafka consumer but not producer brokers

Open matt-psaltis opened this issue 3 years ago • 1 comments

When the ingester boots it logs

msg":"Kafka factory","producer builder":{"Brokers":["127.0.0.1:9092"]

Kafka is not hosted in the ingester pod and so this crashes the pod.

I believe that the ingester deploy should either:

  1. Additionally include KAFKA_PRODUCER_BROKERS into the environment variables
  2. Replace KAFKA_CONSUMER_BROKERS with KAFKA_PRODUCER_BROKERS

See: https://github.com/jaegertracing/helm-charts/blob/aee420f6361775c326e0d258184ac79a1cd4153d/charts/jaeger/templates/ingester-deploy.yaml#L69

As a workaround, I tried the following custom values block when running the helm chart:

ingester:
  enabled: true
  extraEnv:
    - name: KAFKA_PRODUCER_BROKERS
      value: jaeger-kafka-headless:9093

This correctly connects to kafka.

matt-psaltis avatar Mar 29 '21 04:03 matt-psaltis

@matt-psaltis Can you add more details as to what is the problem ? Are you using these instrucitons: https://github.com/jaegertracing/helm-charts/tree/main/charts/jaeger#installing-the-chart-with-ingester-enabled-using-a-new-kafka-cluster

AFAIK, this chart works as it is when kafka is installed as a dependency and ingester is enabled. On your suggestion and point 1 above (re: KAFKA_PRODUCER_BROKERS), these are set on the collector as that is the one sending spans to Kafka (Ingester consumes them from Kafka and sends them to your storage)

mehta-ankit avatar Apr 22 '21 19:04 mehta-ankit