[jaeger] Adds ability to set enableServiceLinks to false

[koalalorenzo]

What this PR does

Attempt to fix: https://github.com/jaegertracing/jaeger/issues/1986 and https://github.com/prometheus/prometheus/issues/7286

Checklist

• [x] DCO signed
• [X] Commits are GPG signed
• [x] Chart Version bumped
• [x] Title of the PR starts with chart name ([jaeger] or [jaeger-operator])

[naseemkullah]

So I just started seeing this in my setup as well, i recently moved jaeger into the same namespace as prometheus, and prometheus emits:

{"caller":"main.go:560","err":"unable to get tracing config from environment: cannot obtain reporter config from env: cannot parse env var JAEGER_AGENT_PORT=udp://11.2.3.4:5775: strconv.ParseInt: parsing \"udp://1.2.3.4:5775\": invalid syntax","level":"error","msg":"Unable to init tracing","ts":"2021-02-09T16:35:46.791Z"}

[naseemkullah]

I think the prometheus server would have to have JAEGER_AGENT_PORT in its env (as done for jaeger query) or enableServiceLinks disabled, WDYT @koalalorenzo ?

[naseemkullah]

(I've since removed jaeger-agent from our infra in favour of otel-collector agent)

[koalalorenzo]

@naseemkullah I am not having a good experience with jaeger.

Our fix consists into temporary change the jaeger name and explore other solutions to replace entirely jaeger

To "fix" it we needed to change enableServiceLinks in the manifests of jaeger, as described in this issue, so this PR is about that anyway.

[naseemkullah]

@naseemkullah I am not having a good experience with jaeger.

Our fix consists into temporary change the jaeger name and explore other solutions to replace entirely jaeger

To "fix" it we needed to change enableServiceLinks in the manifests of jaeger, as described in this issue, so this PR is about that anyway.

That issue is about the jaeger query, (I would know I created the issue), I also have a release called jaeger. Please see my comment about Prometheus emitting a log. What issue are you facing? Which component is producing an error?

It sound like you are facing issues with prometheus erroring out about JAEGER_AGENT_PORT but you would have to confirm.

[koalalorenzo]

It sound like you are facing issues with prometheus erroring out about JAEGER_AGENT_PORT but you would have to confirm.

Yes correct.

[naseemkullah]

Thanks @koalalorenzo! lgtm, but all checks will need to pass before merging though.

[koalalorenzo]

I think that the commit from GitHub adds the issue as it is not signed nor signed with a GPG :(

Not sure how to fix it

[naseemkullah]

Hi @koalalorenzo GPG seems ok, its the DCO that needs to be signed in this case and conflicts need to be resolved to get this merged.

[jonbcampos-alto]

+1

[mehta-ankit]

Hi @koalalorenzo GPG seems ok, its the DCO that needs to be signed in this case and conflicts need to be resolved to get this merged.

@koalalorenzo If you are still looking to push this through. This seems to be the issue:-

[banschikovde]

I ran into a similar problem today:(