helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[jaeger-operator] Added config to make operator watch in arbitrary namespaces

Open davelosert opened this issue 4 years ago • 6 comments

The current helm-chart only allows a somewhat "all or nothing" strategy when it comes to RBAC and watching namespaces: Either the operator only has rights and watches the namespace it was deployed to or it has cluster-wide permissions with a ClusterRoleBinding.

This PR introduces a configuration to watch for arbitrary namespaces. If set, it also creates a ClusterRole, but only RoleBindings in all defined namespaces.

davelosert avatar May 21 '20 10:05 davelosert

Setting WATCH_NAMESPACE to a comma-separated list currently does not work with the operator due to a bug I reported in the operator-repository

So I guess this PR should only be merged once that bug got fixed.

davelosert avatar May 25 '20 09:05 davelosert

@davelosert can you update this PR? so we can finish the review and merge. If this makes no sense anymore feel free to close it

cpanato avatar Aug 22 '20 08:08 cpanato

@cpanato : Updated the PR and adjusted the version. Should be ready for merge now 🙂

davelosert avatar Aug 27 '20 05:08 davelosert

What's keeping this PR from getting merged? I'm currently experiencing an issue with the namespaces and I think this could fix it.

rafaribe avatar Jun 21 '21 11:06 rafaribe

Any updates?

DodgeCamaro avatar Dec 08 '21 11:12 DodgeCamaro

I'm not sure the logic here is correct, nor is it correct currently either, as setting jaeger.namespace should override the release namespace. If this extra logic is actually required at that point it should be layered on top of this making sure that the CR created by the chart can always be observed.

stevehipwell avatar Jan 31 '22 12:01 stevehipwell