documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Migration to docsy theme

Open yurishkuro opened this issue 1 year ago • 12 comments

Jaeger website today is using a completely custom theme. This creates a maintenance headache as we run into various layout bugs (e.g. #744, #745). We also have issues with some old dependencies for CASS like bulma (#730).

I looked around in other CNCF projects and noticed that both OpenTelemetry and Kubernetes websites are using https://github.com/google/docsy theme, which is likely much better supported.

Of course, it's not a very trivial job to replace the theme, as we also have plenty of CSS customizations that we would want to keep. So before we really decide to do that we need some investigation, e.g. just trying out enabling the docsy theme and spot-checking what would break in Jaeger as a result, and collect the findings into a report.

One thing we'd need to do is customize the color schemes to match the existing Jaeger website (https://www.docsy.dev/docs/adding-content/lookandfeel/)


Questions to clarify requirements & design objectives

  • [x] #911 - no
  • [ ] #892
  • [ ] ...

Prep & clean up

  • [x] #894
  • [x] #895
  • [x] #896
  • [x] Consolidate NPM packages and more:
    • [x] #903
    • [x] #905
  • [x] #904
  • [x] #901
  • [x] #908
  • [x] #915
  • [ ] #985
    • [ ] #910
  • [ ] ...

Tasks

  • [x] Add Docsy as NPM package - #903
  • [x] #909
  • [x] #912
  • [ ] Set up the docsy branch:
    • [x] Create docsy branch
    • [ ] Adjust build instructions to use hugo.docsy config
    • [ ] Configure site preview
  • [x] #913
  • [ ] ...
  • [ ] Drop pre-docsy front matter that is no longer needed, such as hasParent, etc.
  • [ ] ...

yurishkuro avatar Sep 19 '24 15:09 yurishkuro

Hi, @yurishkuro Did you get help with this issue? I worked on a similar project for theupdateframework during my LFX mentorship program Term 2 2024. I would be glad to assist.

Dindihub avatar Nov 16 '24 12:11 Dindihub

@Dindihub We do need help.

yurishkuro avatar Nov 16 '24 15:11 yurishkuro

/cc @nate-double-u, since we talked about this during our techdocs call this morning. @yurishkuro - we were curious if you had create a ticket for this?

Btw, @Dindihub contributed to the bulk of the base work of the following:

  • https://github.com/theupdateframework/theupdateframework.io/pull/105

I'm about to wrap up the Docsy migration for the in-toto project. I plan to look into what would be involved for this project. Maybe @Dindihub will look into it before then too.

chalin avatar Nov 19 '24 17:11 chalin

we were curious if you had create a ticket for this?

@chalin sorry, I didn't follow - are you asking about the JIRA ticket I opened long time ago? That one was more about informational structure review / recommendations (especially since we just rolled out new documentation for Jaeger v2).

yurishkuro avatar Nov 19 '24 18:11 yurishkuro

Thanks for the context. I was wondering if you had opened a new ticket that I might not have been aware of (not an obligation of course).

chalin avatar Nov 19 '24 18:11 chalin

@chalin fwiw upgrading to docsy would be much higher priority

yurishkuro avatar Nov 19 '24 18:11 yurishkuro

/cc @nate-double-u, since we talked about this during our techdocs call this morning. @yurishkuro - we were curious if you had create a ticket for this?

Btw, @Dindihub contributed to the bulk of the base work of the following:

I'm about to wrap up the Docsy migration for the in-toto project. I plan to look into what would be involved for this project. Maybe @Dindihub will look into it before then too.

Noted. Thanks @chalin

Dindihub avatar Nov 20 '24 09:11 Dindihub

@yurishkuro - we're discussing this as possibly in scope for 2025. Btw, I'd remove the good first issue label since this work requires a lot of expertise, and is an undertaking that will span weeks.

chalin avatar Dec 10 '24 19:12 chalin

@chalin removed good first issue. When do you expect to come to a decision and have clarity on the timeframes?

yurishkuro avatar Dec 10 '24 19:12 yurishkuro

@yurishkuro - before year's end. Either @nate-double-u or I will reach out (possibly via Slack and or the Jira ticket open for this repo).

chalin avatar Dec 10 '24 21:12 chalin

@yurishkuro - in case you are wondering: I'm spending some initial time studying the current website information architecture (IA), custom theme, layouts, etc. Working on peripheral tasks (like external link checking), not directly related to the Docsy migration, is a practical and useful way for me to get a deeper understand of the site features, so that I can better prepare questions for you, and plan the migration.

Can you assign this issue to me?

chalin avatar May 31 '25 14:05 chalin

@yurishkuro - FYI, I'll be OOO for a few weeks. I'll be resuming the migration as soon as I can.

chalin avatar Jun 23 '25 14:06 chalin

  • Done! 🎉
  • Closed by #1023
  • Next steps via #1024

chalin avatar Nov 13 '25 07:11 chalin

@yurishkuro - btw, I've noticed that the new site has better Lighthouse ratings, e.g.:

Image

/cc @nate-double-u

chalin avatar Nov 13 '25 08:11 chalin

Thanks you @chalin for a massive upgrade of the site! 🚀🎉

yurishkuro avatar Nov 13 '25 13:11 yurishkuro

I'm glad that you like it. I've tagged some very useful Docsy improvements to upstream. ✨ Thanks for your patience in getting this completed. I'm pleased with the result too. 🙌🏻 As I upstream changes to Docsy, I'll update this repo and remove the Docsy overrides. That will help reduce technical debt and increase ease of maintenance and Docsy upgrades in the long term.

chalin avatar Nov 13 '25 13:11 chalin