documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Published 20 hours ago • verified publisher icon jaegertracing

Specifically call out that Sampler Const is not supported in remote

Open aaronkorver opened this issue 6 years ago • 3 comments

Well, I spent a few hours scratching my head on why my type:const was not being honored in the strategies.json file. Then I dug into the code and saw it was because it isn't supported. The Sampling page in the docs lists it as valid, but there is one line at the very bottom that just says 'ratelimiting' and 'probabilistic' are supported. Would have saved me some frustration if this was more explicit.

However, I did learn more about the project by digging into the source code..so win-win?

aaronkorver avatar May 04 '18 18:05 aaronkorver

sorry about that - care to make it win-win-win by submitting a PR? Where is it not supported, on the backend or in the clients?

yurishkuro avatar May 04 '18 19:05 yurishkuro

Yup, I'm planning on it. https://github.com/jaegertracing/jaeger/blob/master/plugin/sampling/strategystore/static/strategy_store.go#L89 is the code that doesn't support using const in the remote sampling

aaronkorver avatar May 04 '18 20:05 aaronkorver

It's not supported on both sides. Server does not have a field for it in SamplingStrategyResponse and therefore the clients won't parse it.

Falco20019 avatar Jun 05 '18 09:06 Falco20019