foo_openlyrics
foo_openlyrics copied to clipboard
jacquesh
[Performance] Don't search lyrics on Internet when offline.
- How you think the new feature/improvement would be helpful, or what problem you think it would solve
Not count against" lyrics not found will not auto search" Save CPU and Battery
Good idea, although off the top of my head I'm not entirely sure how to characterise "when offline". Windows has some mechanism for determining this so we may be able to hook into that. Will require some investigation.
how to characterise "when offline". Windows has some mechanism for determining this so we may be able to hook into that. Will require some investigation.
Ask peter to include it in v2
Good idea, although off the top of my head I'm not entirely sure how to characterise "when offline". Windows has some mechanism for determining this so we may be able to hook into that. Will require some investigation.
Just Ping 1.1.1.1 or 9.9.9.9 on start up and every 2 minutes then
No idea why I'm being pinged on this, But I searched and found this component is using http_client from the fb2k SDK exactly like I do. I know from experience it takes around 10 seconds to timeout when offline. So what? I've lived with it for years and so have many others. It's a big nothing burger.
If people want to re-invent the wheel to get an "instant" fail, that's on them.
@marc2k3 sorry for pinging you I saw you sharing your f2k dev experience on the component repo so i thought I should ask you. if you say i would ping you again.