atom-git-control icon indicating copy to clipboard operation
atom-git-control copied to clipboard

Update git-control-view.coffee

Open jayspirits opened this issue 8 years ago • 7 comments
trafficstars

This is a fix from split of undefined issue. Used 'repo.workingDirectory' from gitRepository object instead of 'path' for setWorkspaceTitle. 'path' is no longer available in the object.

jayspirits avatar Oct 13 '17 08:10 jayspirits

thanks @jayspirits for those who don't know how to fix until the new version is released: move to C:\Users\[username]\.atom\packages\git-control\lib\git-control-view.coffee and change line 76 to:
@setWorkspaceTitle(git.getRepository().repo.workingDirectory.split('/').reverse()[1])

ttristan avatar Oct 23 '17 06:10 ttristan

@ts-de Making that change to line 76 allowed me to load the package, but attempting to select a repo using the "Project" button returns the same error noted in #248.

areichman avatar Oct 23 '17 10:10 areichman

I'm running into the same issues, I made the change that @ts-de suggested, which resolve the first error. However now when trying to switch projects I get the error as detailed in #248

Generic42 avatar Oct 25 '17 20:10 Generic42

I made the additional change referenced here https://github.com/jacogr/atom-git-control/issues/245#issuecomment-336805167

Now I can switch projects properly.

Generic42 avatar Oct 25 '17 20:10 Generic42

I think you also need to add the workinDirectory in project-dialog.coffe line 46 due to the same issue. I also suspect that line 33 is also affected.

gforge avatar Nov 23 '17 21:11 gforge

Thanks it works

Dharshan2004 avatar Aug 23 '18 09:08 Dharshan2004

please merge this

kaizvn avatar Feb 11 '19 09:02 kaizvn