gha-find-replace icon indicating copy to clipboard operation
gha-find-replace copied to clipboard

Regular expression syntax not documented

Open mikeparker opened this issue 4 years ago • 2 comments

The docs say 'can be a regex' but if I give a piece of text with regex-like characters, it gets confused, e.g. terraform?ref=v0.3.0 doesn't work. Can we have an 'exact string match' option?

Different languages have different regular expression syntax and engines, can you document which you're using?

Thanks!

mikeparker avatar Sep 21 '20 23:09 mikeparker

Thanks for raising this @mikeparker.

it gets confused, e.g. terraform?ref=v0.3.0 doesn't work

As the input is a regular expression you must escape characters like ?, . and =.

Can we have an 'exact string match' option?

I would be happy to review a PR to add this feature. But I don't have time to add this myself at the moment. Sorry!

Different languages have different regular expression syntax and engines, can you document which you're using?

I've updated the README with a link to the Golang docs on regular expressions. I hope that helps!

jacobtomlinson avatar Sep 22 '20 10:09 jacobtomlinson

Have you found time to implement this feature since? Is help-wanted on this PR?

ghost avatar Oct 03 '21 15:10 ghost