netsuite icon indicating copy to clipboard operation
netsuite copied to clipboard

Published 20 hours ago • verified publisher icon jacobsvante

WebServiceCall decorator is bypassed

Open byron-lambda opened this issue 2 years ago • 1 comments

zeep creates types dynamically for ComplexType values. These new types have the class zeep.objects.ComplexType so isinstance(response, zeep.xsd.ComplexType) is always False, which effectively bypasses the WebServiceCall decorator here:

https://github.com/jacobsvante/netsuite/blob/9d7bdb39bdf50c246b6b0abd6fa12d65f8e57d61/netsuite/soap_api/decorators.py#L37

I'm not sure of the best way to resolve this. Is the isinstance test necessary?

byron-lambda avatar Sep 03 '22 06:09 byron-lambda

Can you submit a PR for this and we can work on it there?

iloveitaly avatar Oct 31 '23 14:10 iloveitaly