bev17 icon indicating copy to clipboard operation
bev17 copied to clipboard

Suggestion for improvement

Open easydev991 opened this issue 2 years ago • 0 comments

Hello! I cloned your repo and noticed something you could improve a bit:

  1. beersScrollView is unused, so it can be safely deleted
  2. navigationDestination modifier can be safely moved from beerListView ZStack to body, right after beerListView:
var body: some View {
        NavigationStack {
            beerListView
                .navigationDestination(for: Beer.self) { // <- here
                    BeerDetailView(beer: $0)
                }
            // ...
        }
    }
private var beerListView: some View {
        List(beerSearchResults) { beer in
            ZStack {
                NavigationLink(value: beer) {
                    EmptyView()
                }
                BeerListCell(beer: beer)
            }
        }

easydev991 avatar Jan 02 '24 10:01 easydev991