crypto Add generic implementation of xorBlock

Add generic implementation of xorBlock

Open piggynl opened this issue 2 years ago • 4 comments

This PR is based on #12 and will fix #13.

The generic implementation doesn't require that it's safe to perform unaligned word-sized loads, but has a poor performance.

Also, I wonder whether the related code can be rewritten to not use unaligned memory accesses?

Apr 03 '22 05:04 piggynl

@jacobsa This fixes a build for us against riscv64 on Buildroot, could you have a look at merging? Thanks 👍🏽

Jun 25 '22 21:06 paralin

https://github.com/skiffos/buildroot/commit/2bd3a08c77b5514b479a81f967bb7191724dd005

Jun 25 '22 22:06 paralin

Hi @paralin,

@piggynl I'm wondering if it might be good to fork this & maintain it as a different import path if the author doesn't merge.

Sure! Do you prefer maintain the fork at aperturerobotics/jacobsa-crypto or piggynl/jacobsa-crypto? I have some ideas on using QEMU on GitHub Action to test packages for different architectures.

Jul 13 '22 04:07 piggynl

@piggynl Since that org already has a number of forked repos under maintenance, I'm happy to put it there.

Do we keep the name jacobsa-crypto? I can change the go.mod there to match.

OK, changed the go.mod & invited you as a maintainer.

Jul 14 '22 22:07 paralin