Jacob Rask

Results 48 comments of Jacob Rask

Do you have any suggestion on the output of the expressions? ``` gettext(`Hello ${name}, welcome`) gettext(`Hello ${name.toUpperCase() + ' ' + lastName.toLowerCase()}, welcome`) gettext(`Hello ${"Mr" + 'Rask'+getSomething(2)}, welcome`) ``` Because...

Ok, I should be able to fix this by setting a limit of how many files to process at once. Thanks for your report, I'll notify you when it's fixed

The reasons I removed it were: 1. I wasn't sure if anyone was using it 2. I prefer good defaults (and forking) over extensive configurability and endless options 3. I...

I think this is needed for build-web as well. Several tools use the ‘module’ field if it exists, the ‘main’ field exports commonjs modules, that should be the only difference...

When upgrading to 6.0.0-beta we got a large number of “Error fetching index.json” errors ![IMG_0590](https://github.com/percy/percy-storybook/assets/58563/24bff11e-68d8-47a6-bd14-394198fbe4dd)

I see. Not exposing the method at all is also divergence from path-to-regexp tooling though. I guess an option on `toRegExp` for whether or not to used named groups is...

> Also: From a socioeconomic point of view, with the rise of electric cars, if we add vehicle fuel mileage, we should consider pairing that with electric mileage and other...

How about adding `:is()` in some cases for minification, like ``` .long-parent .child, .long-parent .child2 // minifies to .long-parent :is(.child, .child2) // instead of .long-parent .child, .long-parent .child2 ```