Jacob Perron
Jacob Perron
> Are you going to work on tailoring these build environments to the latest development environment? Due to resource constraints, I suspect it will be difficult for us to support...
The workflow is refusing to run: https://github.com/ros2-java/ros2_java/actions/runs/123058318 After some searching, it sounds like we need to edit the settings for this repository (or the ros2-java org) to allow third-party GitHub...
@esteve Thanks :bow: For Linux, it looks like a new flake8 error upstream. I think https://github.com/ament/ament_lint/pull/252 should resolve the issue ultimately. I'll continue looking into what's up with the Windows...
I've gotten one step further with Windows CI. Looks like I've run into a known issue with the ros-tooling/setup-ros action (https://github.com/ros-tooling/action-ros-ci/issues/79).
If I'm not mistaken, building Android packages (like the examples) needs some work and depends on https://github.com/ros2-java/ros2_java/issues/137. Any help in with this is much appreciated.
If you are able to contribute documentation for how to enable security for rcljava on Android, I'm happy to review a pull request :)
Can you explain the use-case for the new interface? Currently, rcljava does support lifespan, but uses a `Duration` type to represent it: https://github.com/ros2-java/ros2_java/blob/093a1019c4847a88dfb6e548646225fce40b0e88/rcljava/src/main/java/org/ros2/rcljava/qos/QoSProfile.java#L39 (same for _deadline_ and _liveliness lease_) I'm...
I think this shouldn't be necessary since we can rely on the upstream version installed on the system. For example on Linux, `test_interfaces_files` should be installed with `rosdep`, or manually...
@ivanpauno Thanks for the review :slightly_smiling_face: > I think we can keep make use of a List backed by an array to get both the performance and the nice API....
> I'm not sure if the change from List to rcl_interfaces.msg.ParameterValue[] is actually worth doing, but the change from List to byte[]` surely is. In which context are you referring...