nanobar
nanobar copied to clipboard
jacoborus
Change Nanobar Color after creating it
see commits (only done on index.js, should be easy on the other ones though)
Could you merge this? I need to change the default color of my nanobar. Thanks!
Looks like the author of this package is no longer actively maintaining it :-(
Am 28.10.2015 um 16:47 schrieb Alexandre Rousseau [email protected]:
Could you merge this? I need to change the default color of my nanobar. Thanks!
— Reply to this email directly or view it on GitHub.
That's the fate of so many (open source projects). Sooner or later, creators get bored and move on to other things. Because of this, I have recently realized that forks are your friends. If an original source creator is no longer around, fork his branch, manage it as your own and don't forget to share (let the world know). Better pick the project carefully though; some code bases are more easily maintained than others. Legibility matters.
I've given some thought to your changes BTW. I'm not sure that styling in code is such a good idea (which is what setColor does). I think the simple addition of a CSS class attribute (e.g., "bar") to the inner div would be better. That way, you've just (and simply) given a way for the "stylists" to do their work the standard way.
Food for thought.
Hey, yea, unfortunately forks can be your best friend at times.
My changes were just a quick fix because I needed a fast way to modify the colors, maybe we could switch over to my fork and discuss how we could implement a better way to modify styles?
Sorry guys, I do not look often notifications. Thanks for the work @fearhat , but I made a new nanobar. I plan to release it in a few days, you can take a look at it here: https://github.com/jacoborus/nanobar/tree/new I hope it solves your problems
