OAuth icon indicating copy to clipboard operation
OAuth copied to clipboard

Add load balancer support

Open brutuscat opened this issue 10 years ago • 3 comments

Add load balancer support using non-standard X-Forwarded headers.

Basically it adds support for AWS Elastic Load Balancer. See docs here x-forwarded-headers and a proposed standard rfc7239 which varies a bit since it does not seem to add support for the X-Forwarded-Port header.

I also confirm that this does work behind a ELB that does SSL termination.

brutuscat avatar Oct 16 '14 09:10 brutuscat

Hi, thank you for your contribution! I'm very busy at the moment, so I'll look at it during the weekend.

jacobkiers avatar Oct 16 '14 15:10 jacobkiers

@brutuscat I'm sorry, I kind of forgot about this PR. Are you still interested in this?

If so, please add tests and then I'll merge it.

jacobkiers avatar Nov 10 '14 12:11 jacobkiers

@jacobkiers I have it working just fine in my fork, so yes I'm interested as anyone who is behind a load balancer will be too I guess... You might also want to add support for this too http://tools.ietf.org/html/rfc7239

brutuscat avatar Nov 10 '14 15:11 brutuscat