unifi-docker icon indicating copy to clipboard operation
unifi-docker copied to clipboard

Published 20 hours ago • verified publisher icon jacobalberty

[BUGFIX] Update docker compose flow

Open cletusw opened this issue 1 year ago • 13 comments

Description

  • Add tty: true to docker-compose.yml so Ctrl-C works to stop watching logs
  • Document how to watch the logs
  • docker-compose (note the hyphen) is deprecated and unsupported as of July 2023: https://docs.docker.com/compose/reference/ . Update docs to docker compose (no hyphen)
  • Update docker-compose.yml to latest version (3)

How Has This Been Tested?

Tested locally. Before I had manually kill the docker attach unifi_logs command from a separate shell. Now Ctrl-C works.

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • [x] My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.

cletusw avatar Oct 13 '23 07:10 cletusw

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Nov 13 '23 02:11 github-actions[bot]

Still relevant and important

cletusw avatar Nov 13 '23 02:11 cletusw

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 28 '24 02:01 github-actions[bot]

Still relevant and important

cletusw avatar Jan 29 '24 17:01 cletusw

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Mar 01 '24 01:03 github-actions[bot]

Still relevant and important

cletusw avatar Mar 01 '24 06:03 cletusw

For whenever this gets checked and merged, may as well just delete the version: line now as it's usually ignored nowadays by Docker Engine. It adjusts versioning automatically based on what's in the compose file.

GamertechAU avatar Mar 21 '24 01:03 GamertechAU

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 20 '24 01:04 github-actions[bot]

Still relevant and important

cletusw avatar Apr 22 '24 17:04 cletusw

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 23 '24 01:05 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 23 '24 01:06 github-actions[bot]

For whenever this gets checked and merged, may as well just delete the version: line now as it's usually ignored nowadays by Docker Engine. It adjusts versioning automatically based on what's in the compose file.

@Gamertech Done, thanks!

cletusw avatar Jun 23 '24 04:06 cletusw

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 24 '24 01:07 github-actions[bot]