Jacob Richman
Jacob Richman
Closing as I've landed this exact change with the trivial test fix in https://github.com/google-gemini/gemini-cli/pull/15218
When in alternate buffer bode without enabling mouse interaction, how should users scrollup and down in the conversation?
@shrutip90 this one is fairly ambiguous. please update with a plan of how you plan to tackle this. What terminals are you trying to support first and how do you...
we need to test actual terminals for this to be useful. how terminals handle kitty protocols and similar is mission critical and can't be mocked
I'm working on it. If you go to `/settings` and enable alternate buffer mode you will see that the flicker is gone. we have some issues to sort out to...
Thank you for this PR! I agree we need to switch to an option that doesn't result in copying line art. I'm discussing with UX and will either approve this...
when I login with oauth and then log in with a key I still get the dialog to enter an API key even though I already have one exported in...
This review was generated by Gemini CLI. Reviewing the changes to prioritize `GEMINI_API_KEY`. **Logic & Correctness:** The prioritization logic in `useAuth.ts` and the flow through `AuthDialog` -> `useAuth` effect ->...
In `packages/cli/src/ui/auth/ApiAuthDialog.tsx`, you use the `isMounted` ref pattern. While acceptable here, consider using a cancellable promise pattern for better async management. Example: ```typescript // const pendingPromise = useRef void }...
Hello! This is a fantastic feature addition. The implementation of background shell commands is a significant UX improvement for long-running tasks. The architecture using `ShellExecutionService` to detach the PTY is...