serverless-plugin-git-variables icon indicating copy to clipboard operation
serverless-plugin-git-variables copied to clipboard

GIT_USER and GIT_EMAIL are not exported by default

Open navrkald opened this issue 4 years ago • 2 comments

This should be very useful feature to know who have something deployed for audit reasons. E.g. our use case is to distinguish if given service was deployed via Jenkins or if it was deployed by some human and who? We have micro-service architecture with a lot of stacks and lambda functions and many small distributed teams so for us it would be extremely helpful if GIT_USER and GIT_EMAIL would be exported by default. I think this feature would be useful for the most of the people and if somebody don't want to populate his email or password, he could always use gitVariablesEnvWhitelist and or gitVariablesTagsWhitelist feature to hide this info.

navrkald avatar Apr 20 '20 20:04 navrkald

If @jacob-meacham still disagree pls don't close it immediately and let people express their opinions.

navrkald avatar Apr 20 '20 21:04 navrkald

I don't think this solves any problem, and is not an issue of this plugin.

If you want to know the user, you could tag with the OS login which is harder to fake. You could also just add another tag in jenkins deployments? Or don't give users permissions to deploy to prod.

f00f avatar May 06 '22 07:05 f00f