jacob-delgado

Getting docs approval can be difficult just due to the limited number of docs maintainers. Most of the time we've been able to get in contact with Eric, but that...

cc @adams-shaun can you help us review this? Do you have any ideas for how we can add tests to this?

Put up a PR to do similar testing for dual-stack clusters similar to how it's done for ipv6 (https://github.com/istio/test-infra/pull/4278). But we still need to create a specific test for this...

Maybe I'm lost, but I think he's referring to https://github.com/istio/istio/blob/a2a370e3469c5b51cdcf1e7897bdeb509438cd17/pilot/pkg/model/service.go#L79 and subsequently https://github.com/istio/istio/blob/a2a370e3469c5b51cdcf1e7897bdeb509438cd17/pilot/pkg/model/service.go#L755 with the idea that dual stack Kubernetes clusters have 2 VIPs, one for IPv4 and IPv6 if...

👍🏽 LGTM. Good catch. The change in Envoy was done to better support dual-stack listeners and matching them to incoming requests. I believe setting it to "::/0" is appropriate as...

Once we agree on a way to fix this, we should try and get this cherry-picked into 1.14 as well.

Closing as this is nearly 3 years old

Everything looks good so far. I'd continue to make progress fixing the existing test. Adding additional unit tests would be some of the biggest gains for dual-stack, in general, and...

Are we able to reproduce any build if we go down this route? I don't like having checked in protos, but as long as we can have something in the...

LGTM, but looking for others' feedback before I approve. The use of "chained" has been especially confusing for people. I'd prefer to even comment out section in values.yaml if possible...