quartz icon indicating copy to clipboard operation
quartz copied to clipboard

feat(preview): manual disabled given files

Open aarnphm opened this issue 1 year ago • 4 comments

Ideally, we want to have a loading skeleton for larger files, but for now, users can disable showing the preview and popover by passing preview: false into the front matter.

This is also helpful for custom pages and items that have additional CSS styling and javascript, since we only fetch the popover-hint content, and there is no guarantee the js would work within nested view.

aarnphm avatar Feb 11 '24 14:02 aarnphm

imo shouldn't need this feature/would hold off until we have the loading skeleton, what HTML file is big enough this is a concern?

jackyzha0 avatar Feb 11 '24 20:02 jackyzha0

We shouldn't need this feature, in my opinion. I would hold off until we have the loading skeleton. What HTML file is big enough that this is a concern?

I tried a 3MB md file and it basically crashed the website.

Hmm what do you recommend for the loading skeleton? Just a spinning wheel?

aarnphm avatar Feb 11 '24 22:02 aarnphm

?? 3mb is like all of shakespeares works what do you have in there that should be git ignored anyways

jackyzha0 avatar Feb 12 '24 05:02 jackyzha0

?? 3mb is like all of shakespeares works what do you have in there that should be git ignored anyways

I was loading shakespeare work for stress-testing lol.

aarnphm avatar Feb 12 '24 05:02 aarnphm