Jacky Zhao

Results 181 comments of Jacky Zhao

this creates multiple popovers per anchor, we should instead 're-scroll' the existing popover to the right location instead of making a new one

yeah looks good! feel free to either combine prs or just submit a new one, that approach makes sense but ill do a more detailed review on the new pr

can you see if https://github.com/jackyzha0/quartz/commit/541b470cfc85c342ba8b7548d58d668b49d8dd85 fixes it?

Can you provide a markdown reproduction? Seems to work on https://quartz.jzhao.xyz/features/callouts

closed in https://github.com/jackyzha0/quartz/pull/1230

these are run once on page load and not on click

please make this an option also, this should be done at the slugging level, not the resolution level https://github.com/jackyzha0/quartz/blob/v4/quartz/util/path.ts#L57

This isn't a Quartz issue, see notes on npm on Windows: https://stackoverflow.com/questions/34600932/npm-eperm-operation-not-permitted-on-windows