Simple-Unity-Audio-Manager icon indicating copy to clipboard operation
Simple-Unity-Audio-Manager copied to clipboard

Suggestion: Add a "Fade" param to PlaySound() / StopSound()

Open LazyEti opened this issue 11 months ago • 2 comments

Hi, I think it would be very useful if it was possible to fade in / out when calling PlaySound() or StopSound().

My suggestion would be to add a float input to each function so they could be called like so: AudioManager.PlaySound (AudioLibrarySounds.player_slide, fade: .5f);

Also, I'm not sure if this is a bug or user error but I tried using SoundChannelHelper.BeginFadeOut() but it's not doing anything Ex:

SoundChannelHelper soundRef = null;
   void Update()
   {
       if (Input.GetKeyDown (KeyCode.Alpha6)) 
              soundRef = AudioManager.PlaySound (AudioLibrarySounds.player_slide,transform);

       if (Input.GetKeyDown (KeyCode.Alpha7)) 
              if (soundRef != null)  soundRef.BeginFadeOut (.1f);       
   } 

Unity Version: 6000.0.26f1

LazyEti avatar Jan 16 '25 12:01 LazyEti

Hi LazyEti,

Thanks for the report, this is indeed a bug with BeginFadeOut.

A fix has been pushed to the development branch. If you aren't already, I'd recommend using the version of JSAM available there. Alternatively, you can download the individual fixed script to your project here.

I've noted your suggestion down, making Fade functionality more visible would indeed be useful👍. I'll have it out in the next version update.

In the meantime, your implementation above is correct. Let me know if you have any other issues!

jackyyang09 avatar Jan 16 '25 16:01 jackyyang09

Gotcha, switching to the dev branch fixed the issue Thanks!

LazyEti avatar Jan 18 '25 02:01 LazyEti