USBqemu-wheel icon indicating copy to clipboard operation
USBqemu-wheel copied to clipboard

eyetoy: frame size off by some bytes

Open jackun opened this issue 5 years ago • 1 comments

https://github.com/jackun/USBqemu-wheel/blob/0ec87bcba7cc0fb555c60e8fca89b86fe42034c5/src/usb-eyetoy/usb-eyetoy-webcam.cpp#L455

Off by sizeof(header1) + sizeof(header2)?

jackun avatar Oct 30 '20 22:10 jackun

The total size (header1+2+mpeg_frame_data) is never calculated or used and mpeg_frame_offset is used to iterate in mpeg_frame_data, not in header1+2+mpeg_frame_data. I can't find any issue. Maybe to verify that data_pk isn't larger than mpeg_frame_size at first step, but is unlikely.

Florin9doi avatar Jan 17 '21 14:01 Florin9doi