Jack

Results 30 comments of Jack

Thanks @shimataro. Just had a look at the merged PR - I don't think it's necessary to _prepend_ a newline. Did you have a chance to see #150 ?

Hi Stef. Thanks for the PR. Whilst this PR does look fine, I think we should take a more general approach such that any headers can be provided. I'd be...

@StefKors Thanks! At first glance, this looks good 👍 I'll have a proper look soon.

What's the benefit to providing an ES module rather than just plain old CJS? I'm not opposed to this change, just interested.

I'm not sure if this change is worthwhile, it breaks older node version and provides nothing new? In general I'm not a fan of globals.

@kfitzgerald You could try https://github.com/jacktuck/node-chartjs as it doesn't depend on globals i've only tested 2.4.0 though

@ewilde Those links are great. I think hedged requests would give an edge over istio/envoy since they do not have this yet. 😍

@amitsaha You'd probably only want to hedge idempotent requests.

Benchmarks might be nice in the README

I had the same thing. I forked @mathiasbynens 's dotfiles which had the following ``` # One of @janmoesen’s ProTip™s for method in GET HEAD POST PUT DELETE TRACE OPTIONS;...