promxy
promxy copied to clipboard
jacksontj
Supporting VictoriaMetric's Extended PromQL
There are some nice convenience functions here: https://github.com/VictoriaMetrics/VictoriaMetrics/wiki/ExtendedPromQL which make writing queries, alerts etc much simpler.
When I try to use them with promxy, I get errors such as:
Error executing query: invalid parameter 'query': parse error at char 3: unknown function with name "ru" for a query such as: ru(kubelet_volume_stats_available_bytes, kubelet_volume_stats_capacity_bytes).
I understand you are using the underlying prometheus libraries for a lot of the query layer and it's likely that layer which is bubbling this error - but would promxy consider adding support for VM's extended PromQL?
I'd definitely consider it, I actually have an issue upstream (https://github.com/VictoriaMetrics/VictoriaMetrics/issues/56) to move the extended promql stuff into a more re-usable library. At this point I don't have the driving use case to spend my time rearchitecting that library to work with promql's types, but I'm definitely for it being in there eventually, PRs are definitely welcome!
FYI, we already have a PR that moves extended PromQL code into a separate library - https://github.com/VictoriaMetrics/VictoriaMetrics/pull/256
From a quick look it'll require some more work to be supported in promxy, as promxy actually uses a forked version of promql with support for NodeReplacer (a mechanism to rewrite the query tree post-parse pre-execution). I have patches to add that functionality on prometheus that I maintain, presumably we could add something similar here.
FYI, the MetricsQL parser has been moved to a separate repository with its own release schedule - https://github.com/VictoriaMetrics/metricsql . This should significantly simplify its' integration into third-party projects such as Promxy.
I'd be very interested in this.
@jacksontj if you can point me at the right bits of code, I'm sure i could come up with a PR.
My company would be happy to sponsor this issue if you'd prefer that.
The place that I think we'd want to implement this is to implement the Engine interface (https://github.com/jacksontj/promxy/blob/master/cmd/promxy/main.go#L188) and then add an option to swap between those.
TBH I haven't spent a lot of time looking into it so I'm not sure exactly how difficult it'll be. I'd be more than happy to review a PR and if you are interested in other options we can discuss those as well :)
I use Promxy in conjunction with VictoriaMetrics. I really lack the support of MetricsQL in Promxy. I'll be glad to see this in the next release. Hope it'll be implemented soon! )
@jacksontj I use Promxy in conjunction with VictoriaMetrics too. I really lack the support of MetricsQL in Promxy. I'll be glad to see this in the next release. Hope it'll be implemented soon! )
+1 Would love to see this implemented. Only thing stopping me from switching to promxy. 🙂
yikes, lads, +1 city in here.
Pull out the editor and get to work. Sheesh.
https://github.com/jacksontj/promxy/issues/253#issuecomment-569083961 @jacksontj where are these patches?
+1 for supporting MetricsQL in promxy. This is extremely important for us to be able to use promxy in our production environment that has multiple victoriametrics clusters. We have 1000s of dashboards built using promQL and metricsQL and can not change them.
Does anyone work on this? If no, I'd like to take it)
@valyala were you able to make any progress? :)
Related, but not the same. With the 0.79.0 release we are getting the following error when querying absent_over_time against a Victoria Metrics backend.
expanding series: remote server http://vmselect.victoriametrics:8481/select/1/prometheus/api/v1/read returned HTTP status 400 Bad Request: remoteAddr: "10.24.11.33:51258"; requestURI: /select/1/prometheus/api/v1/read; unsupported path requested: "/select/1/prometheus/api/v1/read"
I understand VM doesn't support remote read. Any workaround?
I understand VM doesn't support remote read. Any workaround?
set remote_read: false in promxy config ;)
