Jack Henschel

Results 118 comments of Jack Henschel

I just want to chime in and say that having the possibility of defining overrides in a `storage.conf.d` directory (like it is currently possible for `containers.conf`) would be super handy...

Alright, at least it's good to know that a PR is welcome for this :-)

Hi Jack! > Long term, I think the best case scenario would be to add a traceslog package Yes, I think that totally makes sense. Let's leave the issue open...

> Long term, I think the best case scenario would be to add a traceslog package that directly supported the new slog package @jackc If someone contributes such an adapter...

> Yes, but I'm not sure if it can be done yet. pgx supports the latest 2 versions of Go. [...] If not, it would need to wait until Go...

In my opinion, the identity provider (Keycloak, Authentik, ...) should decide / enforce whether the user logs in with 2FA or not.

> Supporting the registry here was one of the reasons we added the prefix in the first place You mean adding the prefix to `BackupStorageLocation.spec.objectStorage.prefix`, correct? > the registry can't...

> > > so maybe this data should actually go to /plugins/openshift-velero-plugin/docker/registry/...: > > > > > > Sure. But it would be a breaking change. or require some migration...

Also I don't understand why `gluster::repo` only passes on `version` to Debian repositories, how are you supposed to select the release number then? https://github.com/voxpupuli/puppet-gluster/blob/master/manifests/repo.pp

@vincent-zurczak Done and done! Thanks for taking a look :-)