jackschu comments

Results 17 comments of


                                            jackschu

Fix: correct ASI for arrow function followed by parenthesized expressions

I took a look and the queries look fine, except I had forgotten to alias `_shorthand_arrow` to `=>` so I pushed a fix for that. I think this is good...

Fix: correct ASI for arrow function followed by parenthesized expressions

@amaanq could you take a look?

HTTP2 Requests hang upon receiving 'Stream closed with error code NGHTTP2_INTERNAL_ERROR'

Sure I can look at adding this patch + some test coverage, It'll likely be outside of my working hours so may be a week or so

HTTP2 Requests hang upon receiving 'Stream closed with error code NGHTTP2_INTERNAL_ERROR'

I took a swing at this but am running into some trouble around `ClientDestroyedError` Currently something like this would result in the promise hanging, I don't think that's correct, and...

Range of jsx_text node is too large

Its a bit strange @llemaitre19 because capturing the whitespace accurately is important for the formatting use case. This is because _some_ whitespace in JSX is effectful. eg see my comment...

Default export of anonymous function declaration is misclassified as function expression

I'm not really sure if the right thing to do here is to 1. Spawn another syntax node for 'function declaration that is part of a default export and therefore...

Improve sharing experience of UI macros

I'm working on adopting perfetto at work (its been super cool so far!). We've got some shared nix/bash scripts that pull a trace and serve it to ui.perfetto.dev over localhost....